Commit Graph

150 Commits

Author SHA1 Message Date
bf68a5f09a Fix VirtualView null exceptions and popup removal race condition
- Fix RemoveAsync race condition: close popup before disconnecting handler
- Add null-safe VirtualView access with try-catch on all platforms
- Properly unsubscribe SizeChanged event in PopupPageHandler
- Fix Android Window type ambiguity with fully qualified name
- Fix README path in csproj

The root cause was layout events firing during popup removal while
the handler was being disconnected. Now we close the popup first
to stop events, then clean up.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-01 23:14:34 +00:00
d5b0054cb9 Add NuGet package assets and fix license
- Add icon.png for NuGet package
- Add PackageIcon and PackageReadmeFile to csproj
- Fix license from MIT to BSD-3-Clause (correct license per original)
- Add Copyright notice crediting original author

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-01 22:21:09 +00:00
c0e669fb30 Add multi-window support for all platforms
- Fork as MarketAlly.Mopups with updated package name and URLs
- Add PushAsync(page, window) overload to IPopupNavigation
- Add AddAsync(page, window) overload to IPopupPlatform
- Windows: Use target window's XamlRoot instead of main window
- iOS: Use target window's UIWindowScene
- MacCatalyst: Use target window's UIWindowScene
- Android: Use target window's Activity DecorView
- Add Microsoft.Maui.Controls/Essentials package references for .NET 9
- Update to version 2.0.0

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-01 22:05:04 +00:00
Tyson Elliot Hooker
f2459e08c9 updated to 1.3.3 2025-05-16 14:36:42 +10:00
Tyson Elliot Hooker
fea722d95d
Merge pull request #157 from spadapet/dev/spadapet/FixXamlHotReloadInPopup
Add support for XAML Hot Reload in Visual Studio (and VS Code)
2025-05-16 13:54:28 +10:00
Tyson Elliot Hooker
0693e0073c
Merge pull request #155 from neretash/master
support removing views on a different stack
2025-05-16 13:53:04 +10:00
Tyson Elliot Hooker
41c0f1599e
Merge pull request #150 from MathiasLopezNareia/android-popup-handler-null
Resolve crash when navigating to PopupPage after app is sent to background
2025-05-16 13:51:52 +10:00
Peter Spada
fdc65ea243 Add support for XAML Hot Reload in Visual Studio 2025-05-07 14:52:12 -07:00
Mathias Lopez
53de4d328b
Merge branch 'master' into android-popup-handler-null 2025-04-03 10:28:10 -03:00
neretash
976a38c084 support removing views on a different stack 2025-04-01 14:56:08 +02:00
Tyson Elliot Hooker
9b9dc85c3f
Merge pull request #152 from AnthonyNjuguna/master 2025-04-01 08:54:09 +11:00
AnthonyNjuguna
17d094c1fb Update AndroidMopups.cs 2025-02-04 11:05:43 +00:00
Mathías López
aec9c9c138 set parent property 2025-01-16 08:57:19 -03:00
Mathías López
228947e790 resolved null reference in PopupPageHandler on Android 2025-01-15 16:10:17 -03:00
Tyson Elliot Hooker
66f585d8c6
Merge pull request #137 from IeuanWalker/NullVirtualView
Null VirtualView
2024-09-30 12:15:06 +10:00
Tyson Elliot Hooker
b5fb645182
Merge pull request #139 from bdovaz/use-interface
Use interfaces instead of implementations
2024-09-30 12:14:20 +10:00
Borja Domínguez Vázquez
f39dd1fc62 Merge branch 'use-interface' of https://github.com/bdovaz/Mopups into use-interface 2024-09-20 10:16:41 +02:00
Borja Domínguez Vázquez
ab141b3a0e Allow to use abstractions 2024-09-20 10:16:37 +02:00
Borja Domínguez Vázquez
ef32c58638 Use IBasePopupViewModel 2024-09-20 09:50:41 +02:00
Ieuan Walker
bce14b7a49
Update PopupWindow.cs 2024-09-17 13:29:26 +01:00
Ieuan Walker
4c1548b5b2
Update PopupWindow.cs 2024-09-17 12:45:44 +01:00
Tyson Elliot Hooker
764c3e200d
Merge pull request #125 from torfluor/multi-window-fix-mac-ios
Open popups on the main application window
2024-09-16 09:55:32 +10:00
Tyson Elliot Hooker
86c6590608
Merge pull request #115 from troy-ob/remove_DescendantRemoved_to_fix_issue_97
Fix: Exception "MauiContext should have been set on parent" when removing a child from its parent layout on iOS
2024-09-16 09:55:08 +10:00
Tyson Elliot Hooker
6e556f454a
Merge pull request #136 from IeuanWalker/Fix/Accessibility
Fix: Accessibility with overlaying popups
2024-09-16 09:54:29 +10:00
Ieuan Walker
d6187191fe
Update AndroidMopups.cs 2024-09-12 13:14:58 +01:00
Ieuan Walker
cea156ee71
Fix accessibility on underlying popups 2024-09-12 13:08:19 +01:00
Ieuan Walker
ef3d3c3781 fix 2024-09-12 09:58:01 +01:00
Tor Øyvind Fluør
e96ea59e84 Open popups on the main application window 2024-06-21 09:56:04 +02:00
Michael Troy
95791d11b7 remove DescendantRemoved 2024-04-05 07:55:42 +02:00
Tyson Elliot Hooker
44b6af7579
Merge pull request #108 from s153625/master
iOS: Popup is closing when background is touched instead of tapped
2024-03-07 15:56:36 +11:00
Tyson Elliot Hooker
86c80de083
Merge pull request #107 from romerotg/master
Fix "VirtualView cannot be null here" on Android when `OnLayout` is fired after the handler is disconnected
2024-03-07 15:46:15 +11:00
Tyson Elliot Hooker
87fb74f03e
Merge pull request #104 from IeuanWalker/WindowsResizing
Fix: Windows window resizing
2024-03-07 15:45:53 +11:00
Tyson Elliot Hooker
18d440b67b
Merge pull request #109 from eichbaum/master
Check for api level when checking for animations
2024-03-07 15:45:40 +11:00
eichbaum
c497b65659
Merge branch 'LuckyDucko:master' into master 2024-02-21 10:57:36 +01:00
Daniel Eichbaum
e09708fe13 Check for Android SDK version 2024-02-21 10:44:09 +01:00
Kevin Hu
2c1bd40c42 Popup was closing when background was touched instead of tapped 2024-02-07 09:20:27 +01:00
Romero Gonçalves
42e60cd8ff Fix "VirtualView cannot be null here" on Android when OnLayout after the handler is disconnected 2024-02-02 17:18:53 -03:00
Ieuan Walker
d484c45d59 fix 2024-01-15 18:54:32 +00:00
Tyson Elliot Hooker
6031022c3e
Merge pull request #102 from LuckyDucko/Net8Upgrade
Net8 upgrade
2024-01-14 17:05:30 +11:00
Tyson Elliot Hooker
6d5a94425d Turned on some dials for hopefully better performance 2024-01-14 17:04:47 +11:00
Tyson Elliot Hooker
3e8c99ccc9 QuickFixes 2024-01-14 16:59:14 +11:00
Tyson Elliot Hooker
ea380cf13e Added in closed PR manually
Pushed to .NET 8
version 1.3.0
2024-01-14 16:49:15 +11:00
Tyson Elliot Hooker
133618da62
Merge pull request #100 from prok155/fix91
Fix "VirtualView cannot be null here"
2024-01-14 15:44:58 +11:00
Adam Drzewiecki
ea52878a3e Fix "VirtualView cannot be null here" 2023-12-19 20:16:35 +01:00
Tyson Elliot Hooker
c51d66ffe0
Merge pull request #90 from mlxyz/master
Cast descendant of GetVisualTreeDescendants() to IElement in DisposeModelAndChildrenHandlers method for better type safety
2023-11-30 13:30:19 +11:00
Tyson Elliot Hooker
a060c430cb
Merge pull request #94 from IeuanWalker/master
Fixes android accessibility handling
2023-11-30 13:29:44 +11:00
Tyson Elliot Hooker
567f29d4ac
Merge branch 'master' into master 2023-11-30 13:29:37 +11:00
Tyson Elliot Hooker
6ab02757d9
Merge pull request #88 from eichbaum/master
only animate with system animations enabled
2023-11-30 13:26:59 +11:00
Ieuan Walker
b884f13aa5 revert collection literals, still in preview and was failing CI builds 2023-11-13 10:50:11 +00:00
Ieuan Walker
7186c6cb62 fix 2023-11-13 10:40:44 +00:00