marketally/marketally.mopups
2
0
Fork 0
Code Issues Packages Releases Wiki

Merge pull request #90 from mlxyz/master

Browse Source 
Cast descendant of GetVisualTreeDescendants() to IElement in DisposeModelAndChildrenHandlers method for better type safety
This commit is contained in:
Tyson Elliot Hooker
2023-11-30 13:30:19 +11:00
committed by GitHub
parent a060c430cb 5098bd4eb5
commit c51d66ffe0
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
Mopups/Mopups.Maui/Platforms/iOS/iOSMopups.cs
View File

@@ -1,11 +1,8 @@
using CoreGraphics;
using Mopups.Interfaces;
using Mopups.Interfaces;
using Mopups.Pages;
using Mopups.Platforms.iOS;
using UIKit;
using UIKit;
namespace Mopups.iOS.Implementation;
internal class iOSMopups : IPopupPlatform
@@ -57,7 +54,7 @@ internal class iOSMopups : IPopupPlatform
handler.ViewController.ModalPresentationStyle = UIModalPresentationStyle.OverCurrentContext;
handler.ViewController.ModalTransitionStyle = UIModalTransitionStyle.CoverVertical;
return window.RootViewController.PresentViewControllerAsync(handler.ViewController, false);
@@ -124,12 +121,15 @@ internal class iOSMopups : IPopupPlatform
private static void DisposeModelAndChildrenHandlers(VisualElement view)
{
foreach (Element child in view.GetVisualTreeDescendants())
foreach (var descendant in view.GetVisualTreeDescendants())
{
IElementHandler handler = child.Handler;
child?.Handler?.DisconnectHandler();
(handler?.PlatformView as UIView)?.RemoveFromSuperview();
(handler?.PlatformView as UIView)?.Dispose();
if (descendant is IElement child)
{
IElementHandler handler = child.Handler;
child?.Handler?.DisconnectHandler();
(handler?.PlatformView as UIView)?.RemoveFromSuperview();
(handler?.PlatformView as UIView)?.Dispose();
}
}
view?.Handler?.DisconnectHandler();