Remove batch file creation to reduce AV false positives

- Refactored all process execution to use direct exe calls
- Added ExecuteExeAsync method for direct process execution
- Removed dynamic .bat file creation that triggered Wacatac detection
- All commands now run ControlMyMonitor.exe directly with arguments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

DellMonitorControl/DellMonitorControl.csproj

@@ -15,9 +15,9 @@
 	</PropertyGroup>
 
 	<PropertyGroup>
-		<Version>1.0.19</Version>
-		<AssemblyVersion>1.0.19.0</AssemblyVersion>
-		<FileVersion>1.0.19.0</FileVersion>
+		<Version>1.1.1</Version>
+		<AssemblyVersion>1.1.1.0</AssemblyVersion>
+		<FileVersion>1.1.1.0</FileVersion>
 	</PropertyGroup>
 
 	<ItemGroup>

DellMonitorControl/MonitorControl.iss

@@ -1,7 +1,8 @@
 #define MyAppName "Monitor Control"
-#define MyAppVersion "1.0.0"
-#define MyAppPublisher "Dang"
+#define MyAppVersion "1.1.0"
+#define MyAppPublisher "MarketAlly"
 #define MyAppExeName "DellMonitorControl.exe"
+#define MyAppIcon "MonitorIcon.ico"
 #define SourcePath "bin\Release\net9.0-windows"
 
 [Setup]
@@ -19,6 +20,7 @@ Compression=lzma
 SolidCompression=yes
 WizardStyle=modern
 PrivilegesRequired=admin
+SetupIconFile={#MyAppIcon}
 UninstallDisplayIcon={app}\{#MyAppExeName}
 
 [Languages]
@@ -30,12 +32,13 @@ Name: "startupicon"; Description: "Start with Windows"; GroupDescription: "Start
 
 [Files]
 Source: "bin\Release\net9.0-windows\*"; DestDir: "{app}"; Flags: ignoreversion recursesubdirs createallsubdirs
+Source: "{#MyAppIcon}"; DestDir: "{app}"; Flags: ignoreversion
 
 [Icons]
-Name: "{group}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"
+Name: "{group}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; IconFilename: "{app}\{#MyAppIcon}"
 Name: "{group}\Uninstall {#MyAppName}"; Filename: "{uninstallexe}"
-Name: "{autodesktop}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Tasks: desktopicon
-Name: "{userstartup}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Tasks: startupicon
+Name: "{autodesktop}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; IconFilename: "{app}\{#MyAppIcon}"; Tasks: desktopicon
+Name: "{userstartup}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; IconFilename: "{app}\{#MyAppIcon}"; Tasks: startupicon
 
 [Run]
 Filename: "{app}\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: nowait postinstall skipifsilent

Library/Helpers/ConsoleHelper.cs

@@ -41,6 +41,46 @@ internal class ConsoleHelper
         return await readTask;
     }
 
+    /// <summary>
+    /// Execute an exe directly with arguments (no cmd.exe or batch file wrapper)
+    /// </summary>
+    public static async Task<(string Output, int ExitCode)> ExecuteExeAsync(string exePath, string arguments, int timeoutMs = 5000)
+    {
+        var p = new Process
+        {
+            StartInfo = new ProcessStartInfo
+            {
+                FileName = exePath,
+                Arguments = arguments,
+                UseShellExecute = false,
+                CreateNoWindow = true,
+                RedirectStandardOutput = true,
+                RedirectStandardError = true
+            }
+        };
+
+        p.Start();
+
+        var readTask = Task.Run(async () =>
+        {
+            var output = await p.StandardOutput.ReadToEndAsync();
+            await p.WaitForExitAsync();
+            return (output, p.ExitCode);
+        });
+
+        var completedTask = await Task.WhenAny(readTask, Task.Delay(timeoutMs));
+
+        if (completedTask != readTask)
+        {
+            try { p.Kill(true); } catch { }
+            return (string.Empty, -1);
+        }
+
+        var result = await readTask;
+        p.Close();
+        return result;
+    }
+
     public static async Task<string> CmdCommandAsync(params string[] cmds) =>
         await CommandAsync(cmdFileName, cmds);
 

Library/Method/CMMCommand.cs

@@ -17,37 +17,36 @@ public static class CMMCommand
     public static async Task ScanMonitor()
     {
         await BytesToFileAsync(new(CMMexe));
-        await ConsoleHelper.CmdCommandAsync($"{CMMexe} /smonitors {CMMsMonitors}");
+        await ConsoleHelper.ExecuteExeAsync(CMMexe, $"/smonitors {CMMsMonitors}");
     }
 
-    public static Task PowerOn(string monitorSN)
-    { 
-        return ConsoleHelper.CmdCommandAsync($"{CMMexe} /SetValue {monitorSN} D6 1");
-    }
-
-    public static Task Sleep(string monitorSN)
+    public static async Task PowerOn(string monitorSN)
     {
-        return ConsoleHelper.CmdCommandAsync($"{CMMexe} /SetValue {monitorSN} D6 4");
+        await ConsoleHelper.ExecuteExeAsync(CMMexe, $"/SetValue {monitorSN} D6 1");
+    }
+
+    public static async Task Sleep(string monitorSN)
+    {
+        await ConsoleHelper.ExecuteExeAsync(CMMexe, $"/SetValue {monitorSN} D6 4");
     }
 
     private static async Task<string> GetMonitorValue(string monitorSN, string vcpCode = "D6", int maxRetries = 2)
     {
         for (int attempt = 0; attempt <= maxRetries; attempt++)
         {
-            var cmdFileName = Path.Combine(CMMTmpFolder, $"{Guid.NewGuid()}.bat");
-            var cmd = $"{CMMexe} /GetValue {monitorSN} {vcpCode}\r\n" +
-                      $"echo %errorlevel%";
-            File.WriteAllText(cmdFileName, cmd);
-            var values = await ConsoleHelper.ExecuteCommand(cmdFileName);
-            try { File.Delete(cmdFileName); } catch { }
+            // Execute directly without batch file wrapper
+            var (output, exitCode) = await ConsoleHelper.ExecuteExeAsync(
+                CMMexe,
+                $"/GetValue {monitorSN} {vcpCode}");
 
             // Empty result means timeout - don't retry, monitor is unresponsive
-            if (string.IsNullOrEmpty(values))
+            if (string.IsNullOrEmpty(output) && exitCode == -1)
                 return string.Empty;
 
-            var value = values.Split("\r\n", StringSplitOptions.RemoveEmptyEntries).LastOrDefault();
+            // Parse output - ControlMyMonitor outputs the value directly
+            var value = output?.Split(new[] { '\r', '\n' }, StringSplitOptions.RemoveEmptyEntries).LastOrDefault()?.Trim();
 
-            if (!string.IsNullOrEmpty(value) && value != "0")
+            if (!string.IsNullOrEmpty(value) && exitCode == 0)
                 return value;
 
             // Only retry on non-timeout failures
@@ -60,9 +59,9 @@ public static class CMMCommand
 
     #region Brightness (VCP Code 10)
 
-    public static Task SetBrightness(string monitorSN, int value)
+    public static async Task SetBrightness(string monitorSN, int value)
     {
-        return ConsoleHelper.CmdCommandAsync($"{CMMexe} /SetValue {monitorSN} 10 {value}");
+        await ConsoleHelper.ExecuteExeAsync(CMMexe, $"/SetValue {monitorSN} 10 {value}");
     }
 
     public static async Task<int?> GetBrightness(string monitorSN)
@@ -75,9 +74,9 @@ public static class CMMCommand
 
     #region Contrast (VCP Code 12)
 
-    public static Task SetContrast(string monitorSN, int value)
+    public static async Task SetContrast(string monitorSN, int value)
     {
-        return ConsoleHelper.CmdCommandAsync($"{CMMexe} /SetValue {monitorSN} 12 {value}");
+        await ConsoleHelper.ExecuteExeAsync(CMMexe, $"/SetValue {monitorSN} 12 {value}");
     }
 
     public static async Task<int?> GetContrast(string monitorSN)
@@ -90,9 +89,9 @@ public static class CMMCommand
 
     #region Input Source (VCP Code 60)
 
-    public static Task SetInputSource(string monitorSN, int value)
+    public static async Task SetInputSource(string monitorSN, int value)
     {
-        return ConsoleHelper.CmdCommandAsync($"{CMMexe} /SetValue {monitorSN} 60 {value}");
+        await ConsoleHelper.ExecuteExeAsync(CMMexe, $"/SetValue {monitorSN} 60 {value}");
     }
 
     public static async Task<int?> GetInputSource(string monitorSN)
@@ -106,7 +105,7 @@ public static class CMMCommand
         var options = new List<InputSourceOption>();
         var savePath = Path.Combine(CMMTmpFolder, $"{monitorSN}_vcp.tmp");
 
-        await ConsoleHelper.CmdCommandAsync($"{CMMexe} /sjson {savePath} {monitorSN}");
+        await ConsoleHelper.ExecuteExeAsync(CMMexe, $"/sjson {savePath} {monitorSN}");
 
         if (!File.Exists(savePath)) return options;
 
@@ -183,7 +182,7 @@ public static class CMMCommand
 
     static async Task ScanMonitorStatus(string savePath, XMonitor mon)
     {
-        await ConsoleHelper.CmdCommandAsync($"{CMMexe} /sjson {savePath} {mon.MonitorID}");
+        await ConsoleHelper.ExecuteExeAsync(CMMexe, $"/sjson {savePath} {mon.MonitorID}");
         var monitorModel = JsonHelper.JsonFormFile<IEnumerable<SMonitorModel>>(savePath);
 
         var status = monitorModel.ReadMonitorStatus();