From 778f4dff1f0475f72f269cf429efb3841e7d0e75 Mon Sep 17 00:00:00 2001 From: logikonline Date: Fri, 9 Jan 2026 18:11:52 -0500 Subject: [PATCH] fix: use WaitGroup.Go() for modernize linter MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace wg.Add(1)/go func()/defer wg.Done() pattern with the simpler wg.Go() method as required by the modernize linter. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- cmd/gitea-cli/cmd/upload.go | 6 ++---- sdk/go/upload.go | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/cmd/gitea-cli/cmd/upload.go b/cmd/gitea-cli/cmd/upload.go index d60677a62e..8fffd032b3 100644 --- a/cmd/gitea-cli/cmd/upload.go +++ b/cmd/gitea-cli/cmd/upload.go @@ -367,9 +367,7 @@ func uploadChunks(ctx context.Context, server, token string, session *UploadSess // Start workers for range parallel { - wg.Add(1) - go func() { //nolint:modernize // Using separate error channel for first-error semantics - defer wg.Done() + wg.Go(func() { for job := range jobs { err := uploadChunk(server, token, session.ID, job.number, job.data) if err != nil { @@ -378,7 +376,7 @@ func uploadChunks(ctx context.Context, server, token string, session *UploadSess } tracker.Add(int64(len(job.data))) } - }() + }) } // Progress display diff --git a/sdk/go/upload.go b/sdk/go/upload.go index 62e5e86461..d371ed65f1 100644 --- a/sdk/go/upload.go +++ b/sdk/go/upload.go @@ -173,9 +173,7 @@ func (cu *ChunkedUpload) uploadChunks(ctx context.Context, reader io.ReaderAt) e // Start workers for range cu.options.Parallel { - wg.Add(1) - go func() { //nolint:modernize // Using separate error channel for first-error semantics - defer wg.Done() + wg.Go(func() { for j := range jobs { if err := cu.uploadChunk(ctx, j.number, j.data); err != nil { errors <- err @@ -184,7 +182,7 @@ func (cu *ChunkedUpload) uploadChunks(ctx context.Context, reader io.ReaderAt) e atomic.AddInt64(&cu.bytesWritten, int64(len(j.data))) cu.reportProgress() } - }() + }) } // Queue chunks